ZTS: small fix for SEEK_DATA/SEEK_HOLE tests #16413
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcmilk
force-pushed
the
fix-seek-data-for-uclibc
branch
from
619eb33 to
fbe3375
Compare
13 tasks
|
Are you sure that defining this does not crash at runtime? |
The test will fail then, because the seek will return -1, that should be fine.
I didn't check uClibc itself. Is there a way that uClibc will get support for it? Edit: oh, uClibc was last updated in 2012?! I can change my PR so that it handles |
tonyhutter
reviewed
Aug 5, 2024
Some libc's like uClibc lag the proper definition of SEEK_DATA and SEEK_HOLE. Since we have only two files in ZTS which use these definitons, let's define them by hand: ``` #ifndef SEEK_DATA #define SEEK_DATA 3 #endif #ifndef SEEK_HOLE #define SEEK_HOLE 4 #endif ``` There should be no failures, because: - FreeBSD has support for SEEK_DATA/SEEK_HOLE since FreeBSD 8 - Linux has it since Linux 3.1 - the libc will submit the parameters unchanged to the kernel Signed-off-by: Tino Reichardt <milky-zfs@mcmilk.de>
mcmilk
force-pushed
the
fix-seek-data-for-uclibc
branch
from
fbe3375 to
2ccefd4
Compare
tonyhutter
approved these changes
Aug 6, 2024
|
I have already tested this patch for Buildroot (uClibc). It works correctly 👏. Thank you all! |
behlendorf
approved these changes
Aug 7, 2024
lundman
pushed a commit
to openzfsonwindows/openzfs
that referenced
this pull request
Sep 4, 2024
Some libc's like uClibc lag the proper definition of SEEK_DATA and SEEK_HOLE. Since we have only two files in ZTS which use these definitons, let's define them by hand: ``` #ifndef SEEK_DATA #define SEEK_DATA 3 #endif #ifndef SEEK_HOLE #define SEEK_HOLE 4 #endif ``` There should be no failures, because: - FreeBSD has support for SEEK_DATA/SEEK_HOLE since FreeBSD 8 - Linux has it since Linux 3.1 - the libc will submit the parameters unchanged to the kernel Signed-off-by: Tino Reichardt <milky-zfs@mcmilk.de> Reviewed-by: Tony Hutter <hutter2@llnl.gov> Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
robn
pushed a commit
to robn/zfs
that referenced
this pull request
Nov 5, 2024
Some libc's like uClibc lag the proper definition of SEEK_DATA and SEEK_HOLE. Since we have only two files in ZTS which use these definitons, let's define them by hand: ``` #ifndef SEEK_DATA #define SEEK_DATA 3 #endif #ifndef SEEK_HOLE #define SEEK_HOLE 4 #endif ``` There should be no failures, because: - FreeBSD has support for SEEK_DATA/SEEK_HOLE since FreeBSD 8 - Linux has it since Linux 3.1 - the libc will submit the parameters unchanged to the kernel Signed-off-by: Tino Reichardt <milky-zfs@mcmilk.de> Reviewed-by: Tony Hutter <hutter2@llnl.gov> Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Some libc's like uClibc lag the proper definition of SEEK_DATA and SEEK_HOLE.
Since we have only two files in ZTS which use these definitons, let's define them by hand.
There should be no failures, because:
There is another pull request for fixing this by skipping the tests here: #16169.
This one is a bit more complex and not finished currently.
Description
I would prefer to make the needed definitions by hand for now:
Some more details about the
Definesthemself:So in the end, ZTS uses the
Defineshere:tests/zfs-tests/cmd/mmap_seek.ctests/zfs-tests/tests/functional/cp_files/seekflood.cSo let's define them in order to do the tests on uClibc based ZTS runs also.
How Has This Been Tested?
Types of changes
Checklist:
Signed-off-by.